Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix QuantityType UNIT_PATTERN regex #3841

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Fix QuantityType UNIT_PATTERN regex #3841

merged 1 commit into from
Oct 10, 2023

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Oct 9, 2023

@jimtng jimtng requested a review from a team as a code owner October 9, 2023 23:14
@jimtng jimtng force-pushed the quantitytype-unit-pattern branch from 78f3124 to 6d6450d Compare October 9, 2023 23:19
@jimtng
Fix QuantityType UNIT_PATTERN regex
2fd33fa 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng force-pushed the quantitytype-unit-pattern branch from 6d6450d to 2fd33fa Compare October 9, 2023 23:24
@jlaur jlaur mentioned this pull request Oct 10, 2023
Merged
wborn
wborn approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the unit tests are nice too!

@wborn wborn merged commit e9d969c into openhab:main Oct 10, 2023
1 of 2 checks passed
@wborn wborn added bug An unexpected problem or unintended behavior of the Core regression labels Oct 10, 2023
J-N-K
J-N-K requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have just one suggestion.

bundles/org.openhab.core/src/main/java/org/openhab/core/library/types/QuantityType.java Show resolved Hide resolved
@J-N-K J-N-K mentioned this pull request Oct 10, 2023
Merged
@jimtng jimtng deleted the quantitytype-unit-pattern branch October 10, 2023 12:01
@holgerfriedrich holgerfriedrich added this to the 4.1 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K requested changes

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core regression
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@jimtng @J-N-K @wborn @holgerfriedrich